[Konsole-devel] Review Request: Implements new TerminalInterfaceV2 functions

[Robert Knight]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/458/#review673
-----------------------------------------------------------


This will need to change pending changes to TerminalInterfaceV2 posted elsewhere for review.  I should clarify something about the Konsole::Session class though - Session::processId() returns the process id of the shell started by Konsole, not the current foreground process.

I suggest:

1.  Rename Session::childName() to foregroundProcessName()
2.  Create a new method Session::foregroundProcessId() which returns Session::getProcessInfo()->pid() (getProcessInfo() returns the process information for the foreground process)

- Robert


On 2009-03-28 10:36:15, Rahman Duran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/458/
> -----------------------------------------------------------
> 
> (Updated 2009-03-28 10:36:15)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This pacth dpends on new TerminalInterfaceV2 patch and implements new functions.
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/Part.h 946098 
>   trunk/KDE/kdebase/apps/konsole/src/Part.cpp 946098 
> 
> Diff: http://reviewboard.kde.org/r/458/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahman
> 
>