[Konsole-devel] Review Request: Make Konsole translucent using Qt 4.5's top-level transparency

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/394/#review564
-----------------------------------------------------------


The problem with this is that due to background inheritance, this will also make e.g. the menu bar and the tab bar translucent, at least on X11. Yet, WA_TranslucentBackground needs to be set on a top-level widget (i.e. the main window). This means further changes are needed, such as disabling background inheritance fore the aforementioned child widgets, unless a more elegant way is found. This is why I stopped at converting the Konsole KPart to WA_TranslucentBackground in my recent commit (r941453 -- I did not ifdev, as Robert told me 4.5 was required by trunk).

- Eike


On 2009-03-22 10:20:51, Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/394/
> -----------------------------------------------------------
> 
> (Updated 2009-03-22 10:20:51)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch sets the Qt:WA_TranslucentBackground window attribute on the main window, allowing Konsole to be translucent using Qt's top-level transparency. Suddenly, Konsole is transparent on my Mac OS X :)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/Application.cpp 888066 
> 
> Diff: http://reviewboard.kde.org/r/394/diff
> 
> 
> Testing
> -------
> 
> Mac OS X 10.5
> 
> 
> Thanks,
> 
> Harald
> 
>