[Konsole-devel] Review Request: Selection stays visible while browsing history

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/280/
-----------------------------------------------------------

(Updated 2009-03-14 10:00:35.216353)


Review request for Konsole.


Summary
-------

If you start top, and select some of the non-static
contents, the selection doesn't disappear when the text below is changed.

This happens because the checkSelection function expects a range, but receives
an X and Y coordinate from the the displayCharacter function. The attached
patch fixes it.


This addresses bug 153372.
    https://bugs.kde.org/show_bug.cgi?id=153372


Diffs (updated)
-----

  /branches/KDE/4.2/kdebase/apps/konsole/src/Screen.h 881297 
  /branches/KDE/4.2/kdebase/apps/konsole/src/Screen.cpp 881297 

Diff: http://reviewboard.kde.org/r/280/diff


Testing
-------

Brief testing on 4.2 branch.  User on bko has tested it for months.


Thanks,

Kurt