[Konsole-devel] Review Request: Selection stays visible while browsing history
Kurt Hindenburg
kurt.hindenburg at gmail.com
Fri Mar 13 04:24:59 UTC 2009
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/280/
-----------------------------------------------------------
Review request for Konsole.
Summary
-------
If you start top, and select some of the non-static
contents, the selection doesn't disappear when the text below is changed.
This happens because the checkSelection function expects a range, but receives
an X and Y coordinate from the the displayCharacter function. The attached
patch fixes it.
Diffs
-----
kdebase/apps/konsole/src/Screen.h 938813
kdebase/apps/konsole/src/Screen.cpp 938813
Diff: http://reviewboard.kde.org/r/280/diff
Testing
-------
Brief testing on 4.2 branch. User on bko has tested it for months.
Thanks,
Kurt
More information about the konsole-devel
mailing list