[Konsole-devel] Review Request: add GUI for 'triple-click selects from current word forwards'

[Rastislav Stanik]

> On 2009-07-23 15:30:49, Kurt Hindenburg wrote:
> > The patch appears to work as expected.  I notice that it seems to pick up an extra CR, although this patch hasn't got anything to do with that.  There is an issue as to whether we want this option in the Advanced tab as it is getting full.

It is _supposed_ to include the CR (unless you mean that the CR at the end is included twice). That is how it works in KDE 3.5 and also for example xterm. Regarding Advanced tab being full - ask the users in bugzilla. This feature is very useful and addictive.


- Rastislav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/722/#review1724
-----------------------------------------------------------


On 2009-05-19 13:15:24, Rastislav Stanik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/722/
> -----------------------------------------------------------
> 
> (Updated 2009-05-19 13:15:24)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Konsole in KDE 4.x is missing an option to make selection from current word forwards - which was present in KDE 3.x.
> The code for making the selection is already present so this patch adds just a GUI to turn this on or off in Advanced page of Edit profile dialog. The default behaviour is to keep current functionality (i.e. triple-click selects whole line).
> 
> 
> This addresses bug 164680.
>     https://bugs.kde.org/show_bug.cgi?id=164680
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.h 970222 
>   /trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.cpp 970222 
>   /trunk/KDE/kdebase/apps/konsole/src/EditProfileDialog.ui 970222 
>   /trunk/KDE/kdebase/apps/konsole/src/Profile.h 970222 
>   /trunk/KDE/kdebase/apps/konsole/src/Profile.cpp 970222 
>   /trunk/KDE/kdebase/apps/konsole/src/ViewManager.cpp 970222 
> 
> Diff: http://reviewboard.kde.org/r/722/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rastislav
> 
>