[Konsole-devel] Review Request: Patch for command-line option to read tab titles and tab commands from file

[Robert Knight]

> On 2009-07-21 10:18:38, arno wrote:
> > Why don't use a XML based file? 
> > This would be probably more useful and expandable for future use. For now just a few tags from a future DTD/Schema would be used, but this may change in future. We could even share a xml-based file through konsole and other applications, using konsole's remote interface through DBus.
> 
> Thomas Dreibholz wrote:
>     The idea of the --tabs-from-file option is to easily create configurations, e.g. to quickly set up a pool of PCs to establish ssh connections to. It is intended that the user manually edits this configuration file by text editor. The usage of XML would make this much more complicated for the user.
>     
>     However, I also see that XML would make much more powerful things possible. May be, powerful XML-based configurations could be added by further options in addition to the simple text form.
> 
> arno wrote:
>     I do use konsole in the very same purpose, that is for managing lots of shells (well, currently not anymore since konsole 2 in KDE 4, but that's going to change). I think, providing a scheme validator everybody should also be able to write his own xml files. I did use a xml based file for my own project [1] and I think, it would be great when we could share one configuration file for such things and konsole itself. It's not, that I would insist on my XML format, I just would like to see a more expandable interoperability here. 
>     
>     
>     [1] http://burnachurch.com/82/ksshmenu-a-graphical-ssh-manager-for-kde/

I'm not so sure about the idea of an XML format.  It would be more flexible - but it would also be more difficult to read and write by hand, which I imagine is how these files are going to be created.

I would stick with the plain text format for now.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1079/#review1696
-----------------------------------------------------------


On 2009-07-21 09:55:49, Thomas Dreibholz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1079/
> -----------------------------------------------------------
> 
> (Updated 2009-07-21 09:55:49)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> The attached patch introduces the new command line option "-tabsfromfile <filename>" to konsole. On startup, konsole reads the file which contains one line for each tab to be created. Syntax is "<tab title>: <command> <args> ..."; comment lines start with '#'. This new option can e.g. be used to conveniently open ssh connections to a pool of PCs; with one tab for each PC. Such a configuration file could look like this:
> # SSH sessions to all Network Testbed PCs
> Control: ssh -CX user at control.my-domain.org
> West:    ssh -CX user at west.my-domain.org
> North:   ssh -CX user at north.my-domain.org
> South:   ssh -CX user at south.my-domain.org
> East:    ssh -CX user at east.my-domain.org
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/Application.h 999292 
>   /trunk/KDE/kdebase/apps/konsole/src/Application.cpp 999292 
>   /trunk/KDE/kdebase/apps/konsole/src/main.cpp 999292 
> 
> Diff: http://reviewboard.kde.org/r/1079/diff
> 
> 
> Testing
> -------
> 
> Tested with SVN revision 999263.
> 
> 
> Thanks,
> 
> Thomas
> 
>