[Konsole-devel] Review Request: Patch for command-line option to read tab titles and tab commands from file

[Thomas Dreibholz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1079/
-----------------------------------------------------------

(Updated 2009-07-21 09:55:49.195190)


Review request for Konsole.


Changes
-------

The alternative format is a good idea. I have updated the patch to use the new format. Also, the option has been renamed to "--tabs-from-file".

Example tabs files:
# SSH sessions to all Network Testbed PCs
title: Essen   command: "ssh -CX demo at essen.my-domain.org"
title: West    command: "ssh -CX demo at west.my-domain.org"
title: North   command: "ssh -CX demo at north.my-domain.org"
title: South   command: "ssh -CX demo at south.my-domain.org"
title: East    command: "ssh -CX demo at east.my-domain.org"


Summary
-------

The attached patch introduces the new command line option "-tabsfromfile <filename>" to konsole. On startup, konsole reads the file which contains one line for each tab to be created. Syntax is "<tab title>: <command> <args> ..."; comment lines start with '#'. This new option can e.g. be used to conveniently open ssh connections to a pool of PCs; with one tab for each PC. Such a configuration file could look like this:
# SSH sessions to all Network Testbed PCs
Control: ssh -CX user at control.my-domain.org
West:    ssh -CX user at west.my-domain.org
North:   ssh -CX user at north.my-domain.org
South:   ssh -CX user at south.my-domain.org
East:    ssh -CX user at east.my-domain.org


Diffs (updated)
-----

  /trunk/KDE/kdebase/apps/konsole/src/Application.h 999292 
  /trunk/KDE/kdebase/apps/konsole/src/Application.cpp 999292 
  /trunk/KDE/kdebase/apps/konsole/src/main.cpp 999292 

Diff: http://reviewboard.kde.org/r/1079/diff


Testing
-------

Tested with SVN revision 999263.


Thanks,

Thomas