[Konsole-devel] Review Request: Added "Copy To All Tabs" feature for konsole

[Robert Knight]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1056/#review1668
-----------------------------------------------------------


Hello Thomas,

Thank-you for the patch.  I think that the UI needs some adjustment however.  I think having separate menu items for 'Copy Input To...' and 'Copy Input to All Tabs' at the same level is going to cause confusion - because it looks like they are unrelated functionality and also because it might not be clear whether 'All Tabs' means 'all tabs in all windows' or 'all tabs in this window'.  Additionally "Copy Input to All Tabs" is verbose and, especially in other languages and with the shortcuts visible will cause the menu to become very wide and look ugly.  I would suggest instead making "Copy Input To..." a sub-menu which has two items under it - "All Tabs in Window" and "Select Tabs..." which brings up the dialog.

- Robert


On 2009-07-18 21:29:13, Thomas Dreibholz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1056/
> -----------------------------------------------------------
> 
> (Updated 2009-07-18 21:29:13)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> konsole in KDE <4.0 had the really convenient feature to send input to all tabs of the same konsole window. KDE 4.x's konsole lacks of this feature. Instead, the "Copy Input To" feature requires to select sessions. Unfortunately, the sessions are not hierachically sorted. So, if opening many sessions (many tabs in many konsole windows) -- e.g. I usually have about 20 to 40 tabs in different windows on 8 screens open -- it is very time-consuming and annoying to find and select/deselect the right session in the "Copy Input To" dialog. On an old KDE 3.5 system, it has been possible to activate/deactivate copying to all tabs of the current window with a single keyboard shortcut. This has been very convenient when managing a pool of PCs by having one konsole window for the pool, with a tab for each SSH connection to one of the PCs. The lack of this KDE 3 feature has prevented me from upgrading my systems to KDE 4.x yet. In order to overcome this problem, the attached patch adds a "Copy To All Tabs" feature to konsole. It works as follows:
> - If "Copy To All Tabs" is activated, "Copy Input To" settings are deactivated and the input is forwarded to all sessions in the same window.
> - If "Copy To All Tabs" is deactivated, the input only goes into the current session.
> - If "Copy Input To" is used when "Copy To All Tabs" is activated, the currently activated sessions are used for the "Copy Input To" dialog which allows for modifying the settings. "Copy To All Tabs" is deactivated then; the settings of "Copy Input To" are used instead.
> 
> 
> This addresses bug 168292.
>     https://bugs.kde.org/show_bug.cgi?id=168292
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 998969 
>   /trunk/KDE/kdebase/apps/konsole/src/SessionController.h 998969 
>   /trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 998969 
>   /trunk/KDE/kdebase/apps/konsole/src/main.cpp 998969 
> 
> Diff: http://reviewboard.kde.org/r/1056/diff
> 
> 
> Testing
> -------
> 
> Compiles against SVN trunk. Tested with SVN revision 998988.
> 
> 
> Thanks,
> 
> Thomas
> 
>