[Konsole-devel] [Bug 199738] A slight reduction in konsole default line spacing

[Robert Knight]

https://bugs.kde.org/show_bug.cgi?id=199738





--- Comment #6 from Robert Knight <robertknight gmail com>  2009-07-12 17:12:14 ---
> This is the first I've seen of this one... Any thought on this?

This means that the terminal application sent some command to Konsole which it
does not support.  I'm not sure what (Esc)[?1034 does.

The suggested patch looks sensible - although some additional refactoring of
the code is needed first:

1.  If the variable _fontHeight no longer contains fontMetrics.height() but the
actual spacing between lines then it needs to be renamed accordingly.

2.  The _lineSpacing variable and setLineSpacing()/lineSpacing() need to either
be renamed (to indicate they are extra spacing added to or removed from the
default spacing) or removed (because they are not used right now I believe)

3.  We need to check that the variable which is now called _fontHeight is
actually the distance between lines of text and that nothing else is added to
or removed from it before rendering.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.