[Konsole-devel] Review Request: Small speedup in Konsole's painting

Harald Fernengel harry at kdevelop.org
Thu Jul 9 21:07:34 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/978/
-----------------------------------------------------------

Review request for Konsole.


Summary
-------

Use only one string when painting, thus reducing one malloc+memcopy per line. QString::reserve should set the initial size once, if we need to shrink the buffer later, it won't realloc.


Diffs
-----

  /trunk/KDE/kdebase/apps/konsole/src/TerminalDisplay.cpp 993475 

Diff: http://reviewboard.kde.org/r/978/diff


Testing
-------

Works like a charm on my Linux box :)


Thanks,

Harald




More information about the konsole-devel mailing list