[Konsole-devel] Review Request: Correct command parsing in profiles

Robert Knight robertknight at gmail.com
Mon Jul 6 15:38:04 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/940/#review1478
-----------------------------------------------------------

Ship it!


Looks good to me

- Robert


On 2009-07-05 07:19:32, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/940/
> -----------------------------------------------------------
> 
> (Updated 2009-07-05 07:19:32)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> Corrects issues when there are extra spaces in command line in the profiles.
> 
> 
> This addresses bug 188230.
>     https://bugs.kde.org/show_bug.cgi?id=188230
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/ShellCommand.cpp 990639 
> 
> Diff: http://reviewboard.kde.org/r/940/diff
> 
> 
> Testing
> -------
> 
> Tested again profiles listed in bug report and my own profiles.
> 
> 
> Thanks,
> 
> Kurt
> 
>




More information about the konsole-devel mailing list