[Konsole-devel] Review Request: Add MacOSX processinfo

Robert Knight robertknight at gmail.com
Mon Jul 6 15:36:57 UTC 2009


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/935/#review1477
-----------------------------------------------------------

Ship it!


Code looks good.  I am unable to test it locally as I do not own a Mac but if it does work correctly, please merge.

- Robert


On 2009-07-05 14:17:35, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/935/
> -----------------------------------------------------------
> 
> (Updated 2009-07-05 14:17:35)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This adds the structure for MacOSX for ProcessInfo - currently only the program name works.
> 
> If there is a better way to do this, please let me know.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 990639 
> 
> Diff: http://reviewboard.kde.org/r/935/diff
> 
> 
> Testing
> -------
> 
> MacOSX 10.5.7
> 
> 
> Thanks,
> 
> Kurt
> 
>




More information about the konsole-devel mailing list