[Konsole-devel] Review Request: Add MacOSX processinfo

[Robert Knight]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/935/#review1467
-----------------------------------------------------------



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment909>

    Should be renamed to MacProcessInfo - since OS-X is the only version of Mac around these days.



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment915>

    Please use a more verbose name for this variable.



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment916>

    This variable needs a more descriptive name



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment917>

    The kp and sb variables need better names



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment918>

    I suggest "Find the tty device associated with 'pid'"
    
    What is /dev/ttys001 in this context? 



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment910>

    Please use the same brace style and naming conventions as the rest of the code:
    
    if ()
    {
    }
    
    Variable names are camelCase



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment919>

    If the data cannot be fetched for any reason the function should return false



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment911>

    Use new,delete[] instead of malloc() for consistency with the rest of the code



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment912>

    Should be ttyName not tty_name



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment920>

    'foremost program' -> foreground program



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment913>

    These functions are not implemented so they should return false



/trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp
<http://reviewboard.kde.org/r/935/#comment914>

    Either resolve this comment (ie. decide whether we should check for DARWIN instead of Q_OS_MACX) or remove it


- Robert


On 2009-07-03 11:28:17, Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/935/
> -----------------------------------------------------------
> 
> (Updated 2009-07-03 11:28:17)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This adds the structure for MacOSX for ProcessInfo - currently only the program name works.
> 
> If there is a better way to do this, please let me know.
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 990639 
> 
> Diff: http://reviewboard.kde.org/r/935/diff
> 
> 
> Testing
> -------
> 
> MacOSX 10.5.7
> 
> 
> Thanks,
> 
> Kurt
> 
>