[Konsole-devel] Review Request: Add process information for FreeBSD

[Robert Knight]

> On 2009-08-31 11:58:12, Robert Knight wrote:
> > Other than the above comments - the patch is good to commit.  I notice that the code for FreeBSD is quite similar to that for MacOS.  Do you think it would be possible to merge the two?  Do you have a KDE SVN account or would you like me to commit it?
> 
> Raphael Kubo da Costa wrote:
>     I took a look at the MacOS implementation, and indeed it calls sysctl() as well, but I'm not sure the code for deviceNumber applies to FreeBSD as well. I've never used MacOS, so the code could be changed either on the FreeBSD or the MacOS side.
>     
>     As for the commit access, I can commit it later (as well as the fix for Solaris, if needed).

The amount of code for MacOS/FreeBSD is quite small so there isn't much harm in keeping it separate for the time being - until someone comes along who uses both and can verify that it would be safe to merge them.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1485/#review2218
-----------------------------------------------------------


On 2009-08-31 03:58:40, Raphael Kubo da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1485/
> -----------------------------------------------------------
> 
> (Updated 2009-08-31 03:58:40)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch implements support for FreeBSD in ProcessInfo.cpp, the same way there's support for Mac and Solaris.
> 
> I'm not a FreeBSD expert (it's not my primary system), so some methods (readEnvironment() and readArguments()) were not implemented, either because I don't know how or because it's not possible in FreeBSD.
> 
> I also had to use free() in readCurrentDir() because of the way kinfo_getfile() is implemented.
> 
> Last but not least, when I compile programs that use kinfo_getfile(), I usually have to pass -lutil to gcc; however, everything compiled fine without any changes to CMakeLists.txt.
> 
> 
> This addresses bug 205648.
>     https://bugs.kde.org/show_bug.cgi?id=205648
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/apps/konsole/src/ProcessInfo.cpp 1017209 
> 
> Diff: http://reviewboard.kde.org/r/1485/diff
> 
> 
> Testing
> -------
> 
> With the patch, using "%u", "%d", "%D", "%n" in tab titles works fine now; previously, I got empty strings.
> 
> 
> Thanks,
> 
> Raphael
> 
>