[Konsole-devel] Review Request: Added "Copy To All Tabs" feature for konsole

[Robert Knight]

> On 2009-08-09 15:26:20, Kurt Hindenburg wrote:
> > Looking at the GUI:
> > 1. Why use CTRL+ shortcuts?  In general, Konsole avoids using CTRL+key - I don't there are any of those shortcuts in Konsole.
> > 2. If you try to make 2+ masters, it appears to nullify all of them.  Should we allow 2 masters?  Should we check there are no duplicate slaves?
> > 3. Should detached windows be separated in the list ?  Line separator?

> I don't there are any of those shortcuts in Konsole.

More generally, the rule is no Single Modifier + Letter/Number shortcuts.  So for example find is Ctrl+Shift+F instead of Ctrl+F as in most applications.  There are a small number of exceptions though.

> Should we allow 2 masters?

For simplicity, I would say no.

> 3. Should detached windows be separated in the list ?  Line separator?

Ideally yes.  Writing a grouping delegate to split up a list into named sections is a bit of pain although I believe there is one in kdelibs that could be used.


- Robert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1056/#review1937
-----------------------------------------------------------


On 2009-08-03 12:30:28, Thomas Dreibholz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1056/
> -----------------------------------------------------------
> 
> (Updated 2009-08-03 12:30:28)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> konsole in KDE <4.0 had the really convenient feature to send input to all tabs of the same konsole window. KDE 4.x's konsole lacks of this feature. Instead, the "Copy Input To" feature requires to select sessions. Unfortunately, the sessions are not hierachically sorted. So, if opening many sessions (many tabs in many konsole windows) -- e.g. I usually have about 20 to 40 tabs in different windows on 8 screens open -- it is very time-consuming and annoying to find and select/deselect the right session in the "Copy Input To" dialog. On an old KDE 3.5 system, it has been possible to activate/deactivate copying to all tabs of the current window with a single keyboard shortcut. This has been very convenient when managing a pool of PCs by having one konsole window for the pool, with a tab for each SSH connection to one of the PCs. The lack of this KDE 3 feature has prevented me from upgrading my systems to KDE 4.x yet. In order to overcome this problem, the attached patch adds a "Copy To All Tabs" feature to konsole. It works as follows:
> - If "Copy To All Tabs" is activated, "Copy Input To" settings are deactivated and the input is forwarded to all sessions in the same window.
> - If "Copy To All Tabs" is deactivated, the input only goes into the current session.
> - If "Copy Input To" is used when "Copy To All Tabs" is activated, the currently activated sessions are used for the "Copy Input To" dialog which allows for modifying the settings. "Copy To All Tabs" is deactivated then; the settings of "Copy Input To" are used instead.
> 
> 
> This addresses bug 168292.
>     https://bugs.kde.org/show_bug.cgi?id=168292
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/desktop/sessionui.rc 999292 
>   trunk/KDE/kdebase/apps/konsole/src/Session.h 999292 
>   trunk/KDE/kdebase/apps/konsole/src/Session.cpp 999292 
>   trunk/KDE/kdebase/apps/konsole/src/SessionController.h 999292 
>   trunk/KDE/kdebase/apps/konsole/src/SessionController.cpp 999292 
>   trunk/KDE/kdebase/apps/konsole/src/main.cpp 999292 
> 
> Diff: http://reviewboard.kde.org/r/1056/diff
> 
> 
> Testing
> -------
> 
> Compiles against SVN trunk. Tested with SVN revision 1006285. Also checked with Valgrind.
> 
> 
> Thanks,
> 
> Thomas
> 
>