[Konsole-devel] Review Request: Konversation konsole tabs rename

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1231/#review1919
-----------------------------------------------------------

Ship it!


Ok, I've now committed revision 6, with some minor fixups for the coding style, a slightly better dialog string and the addition of also setting the new name in the treelist version of the tab bar when in use. Thanks!

PS.: I've requested a "konversation" group on reviewboard with KDE's sysadmins so Konversation patches won't get filed against Konsole again in the future.

- Eike


On 2009-08-05 21:19:35, Antonio Gattoo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1231/
> -----------------------------------------------------------
> 
> (Updated 2009-08-05 21:19:35)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> can rename Konsole tabs now
> 
> 
> This addresses bug 151703.
>     https://bugs.kde.org/show_bug.cgi?id=151703
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/network/konversation/src/viewer/viewcontainer.h 1007295 
>   /trunk/extragear/network/konversation/src/viewer/viewcontainer.cpp 1007295 
> 
> Diff: http://reviewboard.kde.org/r/1231/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonio
> 
>