[Konsole-devel] Review Request: Konversation konsole tabs rename

[Antonio Gattoo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1231/
-----------------------------------------------------------

(Updated 2009-08-05 17:45:02.679489)


Review request for Konsole.


Changes
-------

[18:45] <Sho_> quartz: 
(a) You can't add the action to the action collection because then it will show up in Configure Shortcuts, which is odd as I wrote
(b) please use "Rename Tab..." rather than "Rename Session" (the "..." is necessary when an action opens a dialog), 
(c) you forgot to call KonsolePanel::setName(), 
(d) maybe it would be nicer to place the dialog stuff in KonsolePanel rather than ViewContainer

(a) now action is not in actioncollection
(b) done
(c) when i apply "Rename Tab..." to current tab, i cant update that note immediately, only when i pick another tab and than this one again. When applied not to current tab everything is ok.
(d) it is not difficult, but in this case i would be forced to use KonsolePanel::getWidget()->parentWidget()->parentWidget() instead of m_tabWidget (may be i'm wrong)


Summary
-------

Now one can rename a Konversation's Konsole tab with rightclick and choose "Rename Session".
It works only for Konsole tabs


This addresses bug 151703.
    https://bugs.kde.org/show_bug.cgi?id=151703


Diffs (updated)
-----

  /trunk/extragear/network/konversation/src/viewer/viewcontainer.h 1007295 
  /trunk/extragear/network/konversation/src/viewer/viewcontainer.cpp 1007295 

Diff: http://reviewboard.kde.org/r/1231/diff


Testing
-------


Thanks,

Antonio