[Konsole-devel] Review Request: Make Konsole translucent using Qt 4.5's top-level transparency

[Robert Knight]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/394/#review865
-----------------------------------------------------------


Konsole currently has an option to disable transparency even when it is supported using the --notransparency flag.  The attribute setting needs to respect this and the X11-specific code from main.cpp needs to be removed.  --notransparency was originally because translucent windows on X11 systems suffered a performance hit and other glitches such as window backgrounds being filled with garbage before they first appeared.  I believe the worst performance issues are now resolved - especially with NVidia but we should leave the option in for at least one more release.

- Robert


On 2009-03-22 10:20:51, Harald Fernengel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/394/
> -----------------------------------------------------------
> 
> (Updated 2009-03-22 10:20:51)
> 
> 
> Review request for Konsole.
> 
> 
> Summary
> -------
> 
> This patch sets the Qt:WA_TranslucentBackground window attribute on the main window, allowing Konsole to be translucent using Qt's top-level transparency. Suddenly, Konsole is transparent on my Mac OS X :)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdebase/apps/konsole/src/Application.cpp 888066 
> 
> Diff: http://reviewboard.kde.org/r/394/diff
> 
> 
> Testing
> -------
> 
> Mac OS X 10.5
> 
> 
> Thanks,
> 
> Harald
> 
>