[Konsole-devel] Review Request: Use QToolButton for Konsole tabbar corner widgets

[Sascha Peilicke]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/509/
-----------------------------------------------------------

(Updated 2009-04-05 08:21:05.366815)


Review request for Konsole and Robert Knight.


Summary
-------

here's a little patch that changes the two corner-widget buttons for new/close 
tab functionality to use QToolButton instead of KPushButton. This way they use 
less space and are more visually pleasant (see screenshots). A result of this 
change is the immediate visibility of the new-tab button's menu. IMHO the 
delayed menu of KPushButton is not really intuitive or even noticeable (to be 
honest, I found that feature only in the code), now it's clear that the new-
button has some extra functionality if click-pressed. Last but not least 
Konsole's tab-bar does now look the same as Konqueror's.


Diffs
-----

  trunk/KDE/kdebase/apps/konsole/src/ViewContainer.h 941727 
  trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp 941727 

Diff: http://reviewboard.kde.org/r/509/diff


Testing (updated)
-------

tested with Konsole trunk


Screenshots
-----------

Visual diff
  http://reviewboard.kde.org/r/509/s/96/


Thanks,

Sascha