[Konsole-devel] [Bug 152761] No session management in KDE 4 - Sessions / directory / tabs not restored on login

[Stefan Becker]

http://bugs.kde.org/show_bug.cgi?id=152761





--- Comment #38 from Stefan Becker <stefan becker nokia com>  2008-09-15 07:00:20 ---
Hi Robert,

(In reply to comment #37)
> 
> An application may have multiple main windows, each window containing multiple
> views (TerminalDisplay instances).  Each view is associated with only one
> session but each session may be associated with multiple views.  This code
> would load all the sessions multiple times, once for each window restored.

No, it doesn't. Quote from KMainWindow::saveGlobalProperties() documentation:

  "This function is similar to saveProperties() but is only called for the very
first main window, regardless how many main window are open."

Trust me, *THIS* statement I verified :-)


> +       // this should not happen
> +       Q_ASSERT(id == 0);
> +       return 0;
> 
> This assert is not needed, you have one at the start of the function with the
> opposite condition.  I would rewrite this sort of loop with just one exit
> point:

Actually the assert is correct, but you are right that it is confusing.


> Please try to avoid mixing formatting and functional changes in the same patch.
>  It makes it more difficult to examine the more important functional changes.

I know, but this is rather difficult as there are several different formatting
styles in use even withing the same file :-/ So when I needed to touch existing
code I decided to unify the style for that part of the code.


BTW: If you want contributors to stick to a certain style than please add the
correct -*- STYLE -*- (e.g. -*- linux-c -*-) in the first line of the file so
that smart editors can adjust their behavior accordingly.


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.