[Konsole-devel] [Bug 172042] Konsole window resizes on new tab to last resized window

[Stefan Becker]

http://bugs.kde.org/show_bug.cgi?id=172042


Stefan Becker stefan becker nokia com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #27872|0                           |1
        is obsolete|                            |
  Attachment #27880|0                           |1
        is obsolete|                            |




--- Comment #15 from Stefan Becker <stefan becker nokia com>  2008-10-14 18:05:24 ---
Created an attachment (id=27880)
 --> (http://bugs.kde.org/attachment.cgi?id=27880)
Restore window size only once

Updated patch according to the comments. I wonder how care_about_geometry
slipped through, though :-P


But testing this simple fix revealed that session restore is completely broken
too. I.e. if I restore my standard konsole session with two tabs I see this:

konsole(15134): old window size QSize(700, 420) 
konsole(15134): new window size QSize(577, 415)

 -> initial window creation, resize to default in konsolerc.

konsole(15134): old window size QSize(577, 415) 
konsole(15134): new window size QSize(582, 700)

 -> resize from session data. So we want this request to go through

konsole(15134): old window size QSize(582, 700) 
konsole(15134): new window size QSize(577, 415)

 -> Add first tab. Resized back to konsolerc size :-(

konsole(15134): old window size QSize(577, 415) 
konsole(15134): new window size QSize(577, 415) 

 -> Add second tab. Resized back to konsolerc size :-(

You of course only notice this when the size in konsolerc is different from the
one in the session. I missed this fact when working on bug #152761 :-(

With the patch applied you'll see only the first resize request, i.e. the
windows will only be restored to the size stored in konsolerc. I'm wondering if
we can check app->isSessionRestored() in applyMainWindowSettings and if we need
a second flag for that.


--- Comment #16 from Stefan Becker <stefan becker nokia com>  2008-10-14 20:03:17 ---
Created an attachment (id=27881)
 --> (http://bugs.kde.org/attachment.cgi?id=27881)
Restore window size only once, but allow resize from session restore

OK, I've added a second flag. Now session restore works correctly, i.e. a
window will be resized twice.


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.