[Konsole-devel] [Bug 172042] Konsole window resizes on new tab to last resized window

[David Faure]

http://bugs.kde.org/show_bug.cgi?id=172042


David Faure faure kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ereslibre at kde.org




--- Comment #10 from David Faure <faure kde org>  2008-10-14 01:21:42 ---
Calling addClient to add the GUI of a given tab, is correct xmlgui usage.

The reason for the applyMainWindowSettings call in finalizeGUI, added by
ereslibre recently, is to handle hiding/showing toolbars when switching
components (in konq, kontact etc.) correctly. Indeed it wasn't meant to resize
windows, AFAIK. But applyMainWindowSettings resizes, by default (makes sense on
startup, but not really later on).

I think we need a new flag in KMainWindow::applyMainWindowSettings, or to split
it up, so that kxmlguiwindow could say "apply toolbar settings", but not "and
restore window size". Splitting up is better than a flag (especially for a
virtual method...).
Another (easier) solution might be to remember "I have restored window size
already" and not do it twice for a given kmainwindow; ereslibre, do you see a
use case where this might break?


-- 
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.