[Konsole-devel] [Bug 159275] [PATCH] Konsole's KPart does not properly set its focus proxy

[Robert Knight]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=159275         




------- Additional Comments From robertknight gmail com  2008-03-14 03:06 -------
>  _viewManager->activeView() is NULL at this point, so the call does nothing.

Well spotted, thank-you.  I fixed this by using the view associated with the controller passed to Part::activeViewChanged() in the 4.0 branch and moved the focus proxy setting into ViewManager in the 4.1 branch (SVN commit r785440)

> is there any point to having focus on the view manager

The view manager itself is not a widget, but it does have a 'main' widget (a splitter used to divide multiple views within a window).  This splitter widget's focus proxy should be set to the visible terminal display which wasn't happening. 

> Also, there seems to be a Part::newTab() method,
> so can the KPart mimic Konsole entirely? 

With some work, yes.  Only the small amount of code in the Application and MainWindow classes are unique to the Konsole application and only the Part class is unique to the embedded terminal.  Everything else is shared between the two.  Tabs are just turned off in the part via the setNavigationMethod() call when the part is created because I have not sorted out how integration with other applications such as Kate and KDevelop which provide their own tabbed views is going to work.