[Konsole-devel] [Bug 160346] Default konsole shortcut for adding bookmarks (Ctrl+B) is a bad idea

Thomas Zander zander at kde.org
Wed Jul 23 17:00:09 UTC 2008

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

------- Additional Comments From zander kde org  2008-07-23 19:00 -------
SVN commit 837041 by zander:

Fixes: Default konsole shortcut for adding bookmarks can not be configured
CCBUG: 160346
    Actions should be added to the action collection prior to displaying the menu, so
    we should create them in the constructor.
    I added a d-pointer to hold references to the actions so we don't just create new ones
    later overwriting the properly-configured ones.
    This commit additionally fixes memory leaks by avoiding the re-creation of the actions every
    time the menu is dirty.  (they were never deleted explicitly)

Note that this commit is on 4.2, so unless someone feels its safe to backport to the 4.1 branch
it will not be released in 4.1

 M  +38 -26    kbookmarkmenu.cc  

WebSVN link: http://websvn.kde.org/?view=rev&revision=837041

More information about the konsole-devel mailing list