[Konsole-devel] [Bug 156071] Thai Support for Konsole

[Robert Knight]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156071         




------- Additional Comments From robertknight gmail com  2008-01-18 16:00 -------
> For Thai it is 3 but I heard that the safe number
> is 5 (for example Khmer needs 5). xterm is using 5 too. 

Ok.  A named constant would be better, eg. "const int MAX_COMBINING_CHARS = 5"

> i attached a new patch (which uses QChar::category(c )==QChar::Mark_NonSpacing > instead)

The same check should presumably also be used in the "if (w==0 && cuX==0)" test.
I think you forgot to attach the updated patch.  

> Or should we fix QPainter::DrawText() to detect this kind of font and
> draw string accordingly instead?  but i imagine that won't be too easy
> (as it could affect a lot of things...) Advise welcomed. 

Thanks for explaining.  In this case I suggest leaving the code as you have done already but add a comment to explain the problem that is being worked around.  It would be worth checking against Qt 4.4 to see if there has been any change.

Can Kate/KWrite render Thai text correctly?  If so it would be worth looking at how the kate part draws the text.

> but if it happens (maybe in junk file), it will draw only 5 characters. 

Ok, that is sensible.