[Konsole-devel] [Bug 156071] Thai Support for Konsole

Jakkapun Kwanroengjai glooffy23 at gmail.com
Fri Jan 18 12:46:51 UTC 2008


------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=156071         




------- Additional Comments From glooffy23 gmail com  2008-01-18 13:46 -------
> +  if (w == 0 && cuX > 0) {
> +    if (screenLines[cuY][cuX-1].rendition & RE_EXTENDED_CHAR)
> +    {

> Looking at the table in konsole_wcwidth.cpp, it seems that w can be 0 when the character is not a combining character, for example the null character and there are two other cases which I don't understand.  Do we need to check the value of QChar::category(c) here to be sure this is the right kind of character to build an extended char sequence?       

thank you for pointing this out. i attached a new patch (which uses QChar::category(c )==QChar::Mark_NonSpacing instead)



More information about the konsole-devel mailing list