[Konsole-devel] [Bug 169054] New: checkbox for hiding size widget
Chali Ahmul M.P.U
chali.ahmul at atlas.cz
Wed Aug 13 17:23:31 UTC 2008
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
http://bugs.kde.org/show_bug.cgi?id=169054
Summary: checkbox for hiding size widget
Product: konsole
Version: 2.1
Platform: Debian testing
OS/Version: Linux
Status: UNCONFIRMED
Severity: wishlist
Priority: NOR
Component: general
AssignedTo: konsole-devel kde org
ReportedBy: chali.ahmul atlas cz
Version: 2.1 (using KDE 4.1.0)
Installed from: Debian testing/unstable Packages
Like in Kde3 konsole, there should be a option to hide the size widget.
---------- patch ---------
diff -bu kdebase-4.1.0/apps/konsole/src/EditProfileDialog.cpp kdebase-4.1.0-new/apps/konsole/src/EditProfileDialog.cpp
--- kdebase-4.1.0/apps/konsole/src/EditProfileDialog.cpp 2008-06-26 03:33:07.000000000 +0200
+++ kdebase-4.1.0-new/apps/konsole/src/EditProfileDialog.cpp 2008-08-13 18:47:34.000000000 +0200
@ -253,6 +253,7 @
// window options
_ui->showMenuBarButton->setChecked( info->property<bool>(Profile::ShowMenuBar) );
+ _ui->showSizeWidgetButton->setChecked( info->property<bool>(Profile::ShowSizeWidget) );
// signals and slots
connect( _ui->dirSelectButton , SIGNAL(clicked()) , this , SLOT(selectInitialDir()) );
@ -269,6 +270,9 @
connect(_ui->showMenuBarButton , SIGNAL(toggled(bool)) , this ,
SLOT(showMenuBar(bool)) );
+ connect(_ui->showSizeWidgetButton , SIGNAL(toggled(bool)) , this ,
+ SLOT(showSizeWidget(bool)) );
+
connect(_ui->environmentEditButton , SIGNAL(clicked()) , this ,
SLOT(showEnvironmentEditor()) );
}
@ -369,6 +373,10 @
{
_tempProfile->setProperty(Profile::ShowMenuBar,show);
}
+void EditProfileDialog::showSizeWidget(bool show)
+{
+ _tempProfile->setProperty(Profile::ShowSizeWidget,show);
+}
void EditProfileDialog::tabTitleFormatChanged(const QString& format)
{
_tempProfile->setProperty(Profile::LocalTabTitleFormat,format);
diff -bu kdebase-4.1.0/apps/konsole/src/EditProfileDialog.h kdebase-4.1.0-new/apps/konsole/src/EditProfileDialog.h
--- kdebase-4.1.0/apps/konsole/src/EditProfileDialog.h 2008-06-26 03:33:07.000000000 +0200
+++ kdebase-4.1.0-new/apps/konsole/src/EditProfileDialog.h 2008-08-13 17:59:35.000000000 +0200
@ -120,6 +120,7 @
void insertRemoteTabTitleText(const QString& text);
void showMenuBar(bool);
+ void showSizeWidget(bool);
void showEnvironmentEditor();
void tabBarVisibilityChanged(int);
void tabBarPositionChanged(int);
diff -bu kdebase-4.1.0/apps/konsole/src/EditProfileDialog.ui kdebase-4.1.0-new/apps/konsole/src/EditProfileDialog.ui
--- kdebase-4.1.0/apps/konsole/src/EditProfileDialog.ui 2008-06-03 11:34:24.000000000 +0200
+++ kdebase-4.1.0-new/apps/konsole/src/EditProfileDialog.ui 2008-08-13 17:59:07.000000000 +0200
@ -32,8 +32,8 @
<rect>
<x>0</x>
<y>0</y>
- <width>429</width>
- <height>476</height>
+ <width>437</width>
+ <height>486</height>
</rect>
</property>
<attribute name="title" >
@ -222,6 +222,16 @
</property>
</widget>
</item>
+ <item>
+ <widget class="QCheckBox" name="showSizeWidgetButton" >
+ <property name="toolTip" >
+ <string>Show new size of the terminal after resizing</string>
+ </property>
+ <property name="text" >
+ <string>Show terminal size after resizing</string>
+ </property>
+ </widget>
+ </item>
</layout>
</widget>
</item>
@ -245,8 +255,8 @
<rect>
<x>0</x>
<y>0</y>
- <width>429</width>
- <height>476</height>
+ <width>437</width>
+ <height>486</height>
</rect>
</property>
<attribute name="title" >
@ -401,8 +411,8 @
<rect>
<x>0</x>
<y>0</y>
- <width>429</width>
- <height>476</height>
+ <width>437</width>
+ <height>486</height>
</rect>
</property>
<attribute name="title" >
@ -584,8 +594,8 @
<rect>
<x>0</x>
<y>0</y>
- <width>429</width>
- <height>476</height>
+ <width>437</width>
+ <height>486</height>
</rect>
</property>
<attribute name="title" >
@ -762,8 +772,8 @
<rect>
<x>0</x>
<y>0</y>
- <width>429</width>
- <height>476</height>
+ <width>437</width>
+ <height>486</height>
</rect>
</property>
<attribute name="title" >
@ -852,8 +862,8 @
<rect>
<x>0</x>
<y>0</y>
- <width>429</width>
- <height>476</height>
+ <width>437</width>
+ <height>486</height>
</rect>
</property>
<attribute name="title" >
@ -897,7 +907,6 @
<string>Allow the output to be suspended by pressing Ctrl+S</string>
</property>
<property name="text" >
- <!-- STRINGFREEZE - Remove extra space after 'Ctrl+S' !-->
<string>Enable flow control using Ctrl+S , Ctrl+Q</string>
</property>
</widget>
diff -bu kdebase-4.1.0/apps/konsole/src/Profile.cpp kdebase-4.1.0-new/apps/konsole/src/Profile.cpp
--- kdebase-4.1.0/apps/konsole/src/Profile.cpp 2008-06-26 03:33:07.000000000 +0200
+++ kdebase-4.1.0-new/apps/konsole/src/Profile.cpp 2008-08-13 18:10:56.000000000 +0200
@ -76,6 +76,7 @
, { LocalTabTitleFormat , "tabtitle" , 0 , QVariant::String }
, { RemoteTabTitleFormat , "RemoteTabTitleFormat" , GENERAL_GROUP , QVariant::String }
, { ShowMenuBar , "ShowMenuBar" , GENERAL_GROUP , QVariant::Bool }
+ , { ShowSizeWidget , "ShowSizeWidget" , GENERAL_GROUP , QVariant::Bool }
, { TabBarMode , "TabBarMode" , GENERAL_GROUP , QVariant::Int }
, { TabBarPosition , "TabBarPosition" , GENERAL_GROUP , QVariant::Int }
, { StartInCurrentSessionDir , "StartInCurrentSessionDir" , GENERAL_GROUP , QVariant::Bool }
@ -153,6 +154,7 @
setProperty(TabBarMode,AlwaysShowTabBar);
setProperty(TabBarPosition,TabBarBottom);
setProperty(ShowMenuBar,true);
+ setProperty(ShowSizeWidget,true);
setProperty(StartInCurrentSessionDir,true);
setProperty(ShowNewAndCloseTabButtons,false);
diff -bu kdebase-4.1.0/apps/konsole/src/Profile.h kdebase-4.1.0-new/apps/konsole/src/Profile.h
--- kdebase-4.1.0/apps/konsole/src/Profile.h 2008-06-26 03:33:07.000000000 +0200
+++ kdebase-4.1.0-new/apps/konsole/src/Profile.h 2008-08-13 18:03:00.000000000 +0200
@ -113,6 +113,8 @
RemoteTabTitleFormat,
/** (bool) Specifies whether the menu bar should be shown in the main application window. */
ShowMenuBar,
+ /** (bool) Specifies whether show size information after resizing the application window. */
+ ShowSizeWidget,
/** (TabBarModeEnum) Specifies when the tab bar should be shown in
* the main application window. */
TabBarMode,
diff -bu kdebase-4.1.0/apps/konsole/src/TerminalDisplay.cpp kdebase-4.1.0-new/apps/konsole/src/TerminalDisplay.cpp
--- kdebase-4.1.0/apps/konsole/src/TerminalDisplay.cpp 2008-06-03 11:34:24.000000000 +0200
+++ kdebase-4.1.0-new/apps/konsole/src/TerminalDisplay.cpp 2008-08-13 18:27:57.000000000 +0200
@ -304,6 +304,7 @
,_scrollbarLocation(NoScrollBar)
,_wordCharacters(": - /_~")
,_bellMode(SystemBeepBell)
+,_visible_size_widget(true)
,_blinking(false)
,_hasBlinker(false)
,_cursorBlinking(false)
@ -1510,7 +1511,9 @
if ( _resizing )
{
+ if (_visible_size_widget)
showResizeNotification();
+
emit changedContentSizeSignal(_contentHeight, _contentWidth); // expose resizeEvent
}
@ -2269,6 +2272,11 @
}
+void Konsole::TerminalDisplay::setSizeWidgetVisibility(bool visible)
+{
+ _visible_size_widget = visible;
+}
+
bool TerminalDisplay::focusNextPrevChild( bool next )
{
if (next)
diff -bu kdebase-4.1.0/apps/konsole/src/TerminalDisplay.h kdebase-4.1.0-new/apps/konsole/src/TerminalDisplay.h
--- kdebase-4.1.0/apps/konsole/src/TerminalDisplay.h 2008-05-21 10:32:54.000000000 +0200
+++ kdebase-4.1.0-new/apps/konsole/src/TerminalDisplay.h 2008-08-13 18:27:59.000000000 +0200
@ -117,6 +117,10 @
void setScroll(int cursor, int lines);
/**
+ * Sets if the size widget is going to be shown or not
+ */
+ void setSizeWidgetVisibility(bool visible);
+ /**
* Returns the display's filter chain. When the image for the display is updated,
* the text is passed through each filter in the chain. Each filter can define
* hotspots which correspond to certain strings (such as URLs or particular words).
@ -717,6 +721,7 @
QString _wordCharacters;
int _bellMode;
+ bool _visible_size_widget; // if the size widget will be show
bool _blinking; // hide text in paintEvent
bool _hasBlinker; // has characters to blink
bool _cursorBlinking; // hide cursor in paintEvent
Common subdirectories: kdebase-4.1.0/apps/konsole/src/tests and kdebase-4.1.0-new/apps/konsole/src/tests
diff -bu kdebase-4.1.0/apps/konsole/src/ViewManager.cpp kdebase-4.1.0-new/apps/konsole/src/ViewManager.cpp
--- kdebase-4.1.0/apps/konsole/src/ViewManager.cpp 2008-05-29 13:18:43.000000000 +0200
+++ kdebase-4.1.0-new/apps/konsole/src/ViewManager.cpp 2008-08-13 18:23:16.000000000 +0200
@ -765,6 +765,9 @
else if ( scrollBarPosition == Profile::ScrollBarRight )
view->setScrollBarPosition(TerminalDisplay::ScrollBarRight);
+ // set visibility of the size widget
+ view->setSizeWidgetVisibility(info->property<bool>(Profile::ShowSizeWidget));
+
// terminal features
bool blinkingCursor = info->property<bool>(Profile::BlinkingCursorEnabled);
view->setBlinkingCursor(blinkingCursor);
More information about the konsole-devel
mailing list