[Konsole-devel] [Bug 145177] New: sz does not start download wizard

[Andreas Schwarz]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=145177         
           Summary: sz does not start download wizard
           Product: konsole
           Version: unspecified
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: konsole-devel kde org
        ReportedBy: schwarz_andreas emc com


Version:           1.6.6 (using KDE KDE 3.5.6)
Installed from:    Gentoo Packages
Compiler:          gcc 4.1.2 
OS:                Linux

When trying to donwload a file from a host using "sz" the proper escape sequence is displayed but the zmodem download dialog does not pop up. Using echo "" | awk ' { printf("\030B00") } ' causes the dialog to display while echo "" | awk ' { printf("**\030B00") } ' does not. 
Debugging showed there is a logical error in TEmulation.cpp function TEmulation::onRcvBlk:
    for(l = i; l < len-1; ++l)
      if ((unsigned char) s[l] < 32)
         break;
causes an escape char in the middle of a string not to be decoded by the main i loop. Correct code should be:
    for(l = i; l < len; l++)
      if ((unsigned char) s[l+1] < 32)
         break;