[Konsole-devel] konsolepart not using actionCollection

[Joe Mason]

Is there a reason konsolepart allocates its own pair of
KActionCollections, "actions" and "settingsActions", instead of just
using actionCollection()?  settingsActions is used to populate the
settings menu, and enable and disable its entries as a group, so it
seems to have some use, but actions only serves to make all actions
private so it's impossible for a program to affect them.  (For instance,
I can't figure out how to change the shortcuts for Copy and Paste in an
app that embeds konsolepart.)

I replaced all instances of "new KAction(..., actions, ...)" with "new
KAction(..., actionCollection(), ...)", and it had no ill effects that I
could see, and made most of the actions visible to the client.  (Those
in the settings menu are still private - not sure how best to fix that.)

Would this be a good patch to submit, or is there some reason for not
using actionCollection() that I'm missing?

Joe