[Konsole-devel] [Bug 107487] (PATCH-2) Please add the xterm-256 colour support.

[lars.doelle at on-line.de]

All,

i think, this is it.

i fixed the transparent-MC bug, i wrote about earlier, tested 3 byte colours, added a
related testscript and tested printing.

Try the ./tests/ct2 (or ./tests/colortest.sh, if you can stand blinking)
and the ./tests/color-spaces.pl, all perhaps using various schemata.

Printing is at least not made worse, as i discovered a bug, but it was already
there. To reproduce it, set the "Linux color" schema, say "man man" and
print using "Pixel for pixel" and "Printer unfriendly" option, to find the highlighted
text not being printed. I did not dig into further it, may be, it is only because it prints
boldly white on white ;^). Default colors should perhaps be treated differently
while printing.

The only other thing, i believe is somehow fishy, is the "0xff" stuff reverted by me in
TEWidget::clearImage. If it ever meant anything at all, which i doubt meanwhile, it
should have broken something that i'm not not aware of, but i don't see what and it
does not have any negative effect in any test. I suppose, the "0xff" is a is a left-over
of some testing, really. Actually, the values set in clearImage should not really have
an effect as long as not paintEvent happens before a setImage comes, which should
happen only during program startup, perhaps, in which case the current setting is a
better default. As no special treatment of "0xff" in setImage is done (and what should
this be?), i would consider this one save either.

-lars
-------------- next part --------------
A non-text attachment was scrubbed...
Name: colorspaces-002.patch
Type: text/x-diff
Size: 27011 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20060626/9c9dd38e/attachment.bin>