[Konsole-devel] [Bug 107487] Please add the xterm-256 colour support.

[Lars Doelle]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=107487         




------- Additional Comments From lars.doelle on-line de  2006-06-24 05:09 -------
Witek,

> Here is the patch.

Thanks for the patch. i've not yet tried out the code, but the patch looks good.

> Memory usage is threefolded.

Don't think this would be an issue. People gave up blaming the konsole to be a
space hog long time ago, already...

> fg_rgb and bg_rgb is used only in 256/true colour mode. Mode is indicated by
> fg == 128 or bg == 128 respectively.

I'll try to merge f and fg_rgb into one 32bit value, using one of the bytes for the
colour space designator, but preserving the overall logic you use. Perhaps i
can preserve the 256 colour indices until drawing this way, too.

> I didn't init colors_256 programmatically, because I didn't know where to do it.

Ok, i'll check for some hook. 256 colour mode is ways nicer now, as you maintain
the system colours. Schemata are not affected any longer. Yep. The patch is
much nicer and exactly to the point. 

> rgbused is used in many places, because of usage of color_table there.

Some stuff is particular to the system colours, e.g. transparency and does
not really apply to 1byte and 3byte colours. That's ok. I'll check the places,
but it all looks reasonable on the first glance, perhaps beside the stuff related
to bold.

> Please, don't ask me to rewrite it again.

This was very brave, Witek ;^) and the result was worth the effort. Again, thanks
for the patch. I think, this basically is it. I'll try to finalise it. I notice a few omission,
most particular save and restore of colours on the stack (sa_cu_*). Please leave
me a bit time to take care for it. I'll post a patch.

-lars