[Konsole-devel] Fwd: Konsole painting

[Kurt V. Hindenburg]

Robert, thanks for your work on Konsole lately.  I haven't touch that code and 
honestly don't know much about it.  I'm forwarding your email to the 
konsole-devel mailing.   Andreas Kling has been working on some paint issues 
lately; and perhaps Lars can help.

----------  Forwarded Message  ----------

Subject: Konsole painting
Date: Friday 21 July 2006 22:40
From: "Robert Knight" <robertknight at gmail.com>
To: kurt.hindenburg at kdemail.net

Hello Kurt,

I have a query about the painting in Konsole, I hope you are the right
person to contact about this - please let me know if not.

Each call to QPainter::drawText seems to have a higher overhead than
in Qt 3, so painting a line of text with one drawText call per
character as Konsole in trunk does at the moment is slow.

I modified the TEWidget::drawTextFixed function (TEWidget.cpp:569) to
draw its input string in one pass instead of per-character, and the
time for "ls /usr/bin" on my system dropped from 4.4s to 2.5s (still
very slow compared with 0.35s for Konsole 1.6.4 but there are other
areas to work on).

The only thing stopping me from doing this is that in said function
there is a weird conditional where the width allowed for the character
is doubled at column 0.  I cannot see any obvious visual difference
whether this is commented out or left in, so I wondered if you knew
why it was there and whether it is essential or not?

Regards,
Robert.

-------------------------------------------------------