[Konsole-devel] [Bug 103554] "Monitor for Activity" and "Monitor for Silence" icons are the same

[Kurt V.Hindenburg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=103554         
kurt.hindenburg kdemail net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From kurt.hindenburg kdemail net  2005-05-15 01:46 -------
SVN commit 413941 by hindenburg:

Copy KDE 3.3's ktip.png to silence.png and idea.png to activity.png for use with Monitor for Activity/Silence.

Will backport without the string changes.

BUG: 103554



 M  +18 -10    trunk/KDE/kdebase/konsole/konsole/konsole.cpp  


--- trunk/KDE/kdebase/konsole/konsole/konsole.cpp #413940:413941
 @ -768,12 +768,14  @
                          SLOT(slotTabRenameSession()) );
    m_tabPopupMenu->insertSeparator();
 
-   m_tabMonitorActivity = new KToggleAction ( i18n( "Monitor for &Activity" ), "idea", 0, this,
-                                        SLOT( slotTabToggleMonitor() ), this);
+  m_tabMonitorActivity = new KToggleAction ( i18n( "Monitor for &Activity" ), 
+      SmallIconSet("konsole"), 0, this, SLOT( slotTabToggleMonitor() ), this );
+  m_tabMonitorActivity->setCheckedState( KGuiItem( i18n( "Stop Monitoring for &Activity" ), SmallIconSet( "activity" ) ) );
    m_tabMonitorActivity->plug(m_tabPopupMenu);
 
-   m_tabMonitorSilence = new KToggleAction ( i18n( "Monitor for &Silence" ), "ktip", 0, this,
-                                       SLOT( slotTabToggleMonitor() ), this);
+  m_tabMonitorSilence = new KToggleAction ( i18n( "Monitor for &Silence" ), 
+      SmallIconSet("konsole"), 0, this, SLOT( slotTabToggleMonitor() ), this );
+  m_tabMonitorSilence->setCheckedState( KGuiItem( i18n( "Stop Monitoring for &Silence" ), SmallIconSet( "silence" ) ) );
    m_tabMonitorSilence->plug(m_tabPopupMenu);
 
    m_tabMasterMode = new KToggleAction ( i18n( "Send &Input to All Sessions" ), "remote", 0, this,
 @ -1033,10 +1035,16  @
                                   SLOT( slotZModemUpload() ), 
                                   m_shortcuts, "zmodem_upload" );
 
-  monitorActivity = new KToggleAction ( i18n( "Monitor for &Activity" ), "idea", 0, this,
-                                        SLOT( slotToggleMonitor() ), m_shortcuts, "monitor_activity" );
-  monitorSilence = new KToggleAction ( i18n( "Monitor for &Silence" ), "ktip", 0, this,
-                                       SLOT( slotToggleMonitor() ), m_shortcuts, "monitor_silence" );
+  monitorActivity = new KToggleAction ( i18n( "Monitor for &Activity" ), 
+      SmallIconSet("konsole"), 0, this,
+      SLOT( slotToggleMonitor() ), m_shortcuts, "monitor_activity" );
+  monitorActivity->setCheckedState( KGuiItem( i18n( "Stop Monitoring for &Activity" ), SmallIconSet( "activity" ) ) );
+
+  monitorSilence = new KToggleAction ( i18n( "Monitor for &Silence" ), 
+      SmallIconSet("konsole"), 0, this,
+      SLOT( slotToggleMonitor() ), m_shortcuts, "monitor_silence" );
+  monitorSilence->setCheckedState( KGuiItem( i18n( "Stop Monitoring for &Silence" ), SmallIconSet( "silence" ) ) );
+
   masterMode = new KToggleAction ( i18n( "Send &Input to All Sessions" ), "remote", 0, this,
                                    SLOT( slotToggleMasterMode() ), m_shortcuts, "send_input_to_all_sessions" );
 
 @ -2993,9 +3001,9  @
                          break;
     case NOTIFYBELL    : state_iconname = "bell";
                          break;
-    case NOTIFYACTIVITY: state_iconname = "idea";
+    case NOTIFYACTIVITY: state_iconname = "activity";
                          break;
-    case NOTIFYSILENCE : state_iconname = "ktip";
+    case NOTIFYSILENCE : state_iconname = "silence";
 			 break;
   }
   if (!state_iconname.isEmpty()