[Konsole-devel] [Bug 96605] New: History 'Number of Lines' - 1 is viewable

[Kurt V.Hindenburg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=96605        
           Summary: History 'Number of Lines' - 1 is viewable
           Product: konsole
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: konsole-devel kde org
        ReportedBy: kurt.hindenburg kdemail net


Version:            (using KDE Devel)

While working on the crash BR95990, I noticed this.

Setting the 'Number of Lines' to 1, gives no History.
Setting to 2, give 1 line of History.
... etc... etc...


This appears to fix it.

--- TEHistory.cpp       28 Jun 2003 10:31:38 -0000      1.25
+++ TEHistory.cpp       8 Jan 2005 19:27:04 -0000
 @ -230,7 +230,7  @ void HistoryScrollBuffer::addCells(ca a[
      m_buffFilled = true;
     }

-  if (m_nbLines < m_maxNbLines - 1) ++m_nbLines;
+  if (m_nbLines < m_maxNbLines) ++m_nbLines;

   // m_histBuffer.remove(m_arrayIndex); // not necessary
   m_histBuffer.insert(m_arrayIndex, newLine);