[Konsole-devel] [Bug 90419] New: PATCH/FIXME: remove global variable keytab_serial

[Kurt V.Hindenburg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
        
http://bugs.kde.org/show_bug.cgi?id=90419        
           Summary: PATCH/FIXME: remove global variable keytab_serial
           Product: konsole
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: konsole-devel kde org
        ReportedBy: public kurt hindenburg name


Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

Any reason not to do this?

===================================================================
RCS file: /home/kde/kdebase/konsole/konsole/keytrans.cpp,v
retrieving revision 1.48
diff -u -p -r1.48 keytrans.cpp
--- keytrans.cpp        22 Sep 2004 20:02:16 -0000      1.48
+++ keytrans.cpp        28 Sep 2004 18:17:07 -0000
 @ -636,8 +636,6  @ KeyTransSymbols::KeyTransSymbols()

 // Global material -----------------------------------------------------------

-static int keytab_serial = 0; //FIXME: remove,localize
-
 static QIntDict<KeyTrans> * numb2keymap = 0L;

 KeyTrans* KeyTrans::find(int numb)
 @ -665,7 +663,7  @ int KeyTrans::count()

 void KeyTrans::addKeyTrans()
 {
-  m_numb = keytab_serial ++;
+  m_numb = numb2keymap->count(); // or m_numb=count();
   numb2keymap->insert(m_numb,this);
 }