[Konsole-devel] KProcess/Kpty: utempter support (BR70794)

Waldo Bastian bastian at kde.org
Mon Jan 19 12:50:28 UTC 2004


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

See bug:70794 With HAVE_UTEMPTER Kpty calls KProcess from commSetupDoneC which 
will hang if the SIGCHLD handler was reset already.

Please review so that I can backport.

Cheers,
Waldo

On Mon January 19 2004 13:00, Waldo Bastian wrote:
> CVS commit by waba:
>
> Make support for UTEMPTER work
>
>
>   M +4 -4      kprocess.cpp   1.131
>
>
> --- kdelibs/kdecore/kprocess.cpp  #1.130:1.131
> @@ -356,4 +356,7 @@ bool KProcess::start(RunMode runmode, Co
>          fcntl(fd[1], F_SETFD, FD_CLOEXEC);
>
> +        if (!commSetupDoneC())
> +          kdDebug(175) << "Could not finish comm setup in child!" << endl;
> +
>          // reset all signal handlers
>          struct sigaction act;
> @@ -364,7 +367,4 @@ bool KProcess::start(RunMode runmode, Co
>            sigaction(sig, &act, 0L);
>
> -        if (!commSetupDoneC())
> -          kdDebug(175) << "Could not finish comm setup in child!" << endl;
> -
>          if (d->priority)
>              setpriority(PRIO_PROCESS, 0, d->priority);

- -- 
bastian at kde.org -=|[ KDE: K Desktop for the Enterprise ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFAC9KUN4pvrENfboIRAr2TAJ0bndosGS0zKDs3JQJ5LkATcTd4fwCgpEik
B4KblwZlZG8gsgK98YmeUEY=
=IigV
-----END PGP SIGNATURE-----



More information about the konsole-devel mailing list