[Konsole-devel] [PATCH] improve On The Spot input style

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tue November 25 2003 16:48, Toshitaka Fujioka wrote:
> Hello,
>
> The attached a patch, improve on the spot input style like a kate(CVS
> HEAD). (composing text background color, selection text background color)

Thank you for your patch.

You use  qstrlen( e->text().local8Bit().data() ); is that in order to get the 
number of columns that the text occupies? I think it would be more correct to 
use something based on konsole_wcwidth(), e.g.

int string_width(conqt QString &txt)
{
  int w = 0;
   for(int i=0; i < txt.length(); i++)
      w += konsole_wcwidth(txt[i].unicode());
  return w;
}

and then use string_width(e->text()) ??

Cheers,
Waldo
- -- 
bastian at kde.org -=|[ SUSE, The Linux Desktop Experts ]|=- bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE/w5L9N4pvrENfboIRAqJiAJ429z7b/z2dzU6aPv8vMTTXJaAowACgouod
0TJQ65N2ZihHKhser/EGcck=
=j1Os
-----END PGP SIGNATURE-----