[Konsole-devel] [Bug 53713] double spaced on some of the font

[Waldo Bastian]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
     
http://bugs.kde.org/show_bug.cgi?id=53713     




------- Additional Comments From bastian at kde.org  2003-02-05 12:24 -------
Subject: Re: [Konsole-devel]  double spaced on some of the font

On Wednesday 05 February 2003 07:39, llch at redhat.com wrote:
> What I did on the following patch is getting total width english glyphs and
> symbols and get the width by avg. it. 

Shouldn't it use the maximum? You want that the whole character fits your cell 
for all (single width) characters. If you average, you pretty much get that 
half of the chars fit and the other half doesn't.

> Also did a "cell drawing" by drawing each character separately to a cell
> width.

Thanks, something like this is indeed needed. How bad does this suck in terms 
of performance? 

Note that "use double width if not ascii" is not correct, we keep track 
internally of characters that are supposed to be double width and that 
information should be used instead.

E.g. setImage knows when a character is double width, because the next 
character will be 0. What might work is to pass fragments to drawAttrStr that 
consist of either only single width or only double width characters and add a 
bool isDoubleWidth to drawAttrStr. Then drawAttrStr can do "cell drawing" 
using the specified width.

It would be nice if you could make a patch based on the above, if not I will 
have a go at it myself in the second half of february.

Cheers,
Waldo