[Konsole-devel] bugfix/speedup

[Paul Pogonyshev]

Stephan Binner wrote:
> On Friday 04 April 2003 01:01, Paul Pogonyshev wrote:
> > Please let me know if i missed something or if it doesn't work under some
> > circumstances.
>
> The patch is bogus: Start something which changes the background, eg mc
> gives a blue background. Cover the Konsole window with another window.
> Bring the Konsole window back to top and you lost the background color.

Here is a revised version which seems to be doing ok with fancy backgrounds.
The slowness of redrawing has been a real problem for me and i have seen a
couple of bug reports on your mailing list about it. I hope this time the
fix is real ;)

regards,
  Paul


Index: TEWidget.cpp
===================================================================
RCS file: /home/kde/kdebase/konsole/konsole/TEWidget.cpp,v
retrieving revision 1.189
diff -u -p -r1.189 TEWidget.cpp
--- TEWidget.cpp	31 Mar 2003 13:03:22 -0000	1.189
+++ TEWidget.cpp	6 Apr 2003 19:53:03 -0000
@@ -411,7 +411,9 @@ void TEWidget::drawAttrStr(QPainter &pai
     }
     else
     {
-      paint.fillRect(rect, color_table[attr->b].color);
+      if (pm || color_table[attr->b].color != color_table[DEFAULT_BACK_COLOR].color
+          || clear || (blinking && (attr->r & RE_BLINK)))
+        paint.fillRect(rect, color_table[attr->b].color);
     }
   }