Bug#42986: [Konsole-devel] Bug#42986: dup2() in freebsd

[Waldo Bastian]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Tuesday 03 September 2002 12:31 am, Michael Samuel wrote:
> [I'm subscribed to the list now, so I this should be the last message
> cut 'n pasted from the archive]
>
> > Good idea. My compiler explains to me that I have revoke() but that it
> > isn't implemented :-]
>
> This should probably be an #ifdef of some sort, then. (I know FreeBSD
> and OpenBSD both have revoke, and FreeBSD's openpty() definately uses
> revoke as I explained).
>
> After checking the glibc source, I don't think Linux with /dev/pts is
> vulnerable, but glibc's openpty without devpts seems just as vulnerable
> as konsole.
>
> Also, after putting in the printf() on the dup2() call, I noticed that
> sometimes when closing the pty, the pty master file descriptor is
> invalidated before chownpty is called, causing the pty ownership not to
> be restored.  This is reproducible when closing konsole via the close
> button, or doing a ctrl-d on the last open terminal. (Typing exit from
> the shell doesn't trigger it)

Does this patch help?

Cheers,
Waldo
- -- 
bastian at kde.org  |   SuSE Labs KDE Developer  |  bastian at suse.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE9dRGEN4pvrENfboIRAqgHAJ0QcKFICg1BTZYNz/UFEY1lj7Ht8wCcCP8Q
2xXmb4vge3gNaXWdVQaFfH0=
=k0lH
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: konsole_pty.patch
Type: text/x-diff
Size: 1958 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20020903/038f3ece/attachment.bin>