Fwd: Bugs relating to KDE ecma/javascript API change (QTE specific
code never updated)
Keith Kyzivat
konq-e@mail.kde.org
Tue, 18 Mar 2003 08:58:16 -0500
This is a multi-part message in MIME format.
--------------060309010409020109060901
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Say, Simon, Paul,
It appears that an API change happened somewhere between KDE2.2->3.1
regarding Javascript, and the kdelibs developers overlooked
updating some #ifdefed code for QT/E.
Do you have any ideas on what approach should we take to fix these
several bugs?
Why is there a need for this Konqueror class, what is the _Konqueror
property, and what does KonquerorFunc do?
(I'm guessing they're all related)...
~Keith
-------- Original Message --------
Subject: Re: Design decisions required...
Date: Mon, 17 Mar 2003 11:47:24 -0500
From: Keith Kyzivat <kkyzivat@attbi.com>
To: Luciano Montanaro <mikelima@virgilio.it>
References: <3E70D320.9080804@attbi.com>
<200303171057.13416.mikelima@virgilio.it> <3E75CB6D.6000601@attbi.com>
<200303171653.02066.mikelima@virgilio.it>
Luciano Montanaro wrote:
>mandag 17 mars 2003, 14:19, skrev du :
>
>
>Sorry for the delay, I was testing the new stubs for KURIFilter.
>I'll commit them in a few minutes, so that the define is not needed anymore.
>
Sounds great! I actually can get away without having clipboard support,
but of course, I'm sure those people that want to use it
on PDAs probably want clipboard support.
>You can find my config.log file in the attachment, together with the script
>I use to compile konq-e. I usually call it like
>
>.localconfigure
>
>or .localconfigure debug
>
Ok, I'll take a look at it.
>For some strange reason the non-debug version does not currently work well
>on my computer (it tends to crash) but works fine on the set-top-box we are
>developing for.
>The -DQT_NO_CLIPBOARD was defined by the script, by the way, so that
>the default Qt library could be used.
>
I'll keep that in mind.
Oh, and I found a few other bugs which I've currently stubbed (no doubt,
they'll come back to haunt me at runtime):
kjs_window.cpp:510-516 - there is no constructor taking an ExecState*
and a UString defined. I simply #if 0'ed it out, removing a response to
the _Konqueror property. It will fall to the default of Undefined()
when someone asks for it.
kjs_window.cpp:1987 - a KonquerorFunc does not derive from Value. Also -
I smell a memory leak if it was to work. - I just stubbed it by
returning Undefined()
The makefiles konq-embed/{lib,src}/Makefile (and associated automake and
in files) explicitly link to qt-mt. Shouldn't this be determined by
configure and it's command line args?
I manually hacked them for qte
>>Thank you for all your help Luciano. I really appreciate it.
>>
>>
>
>You are welcome, with more people working on this, we'll have a better
>browser sooner.
>
True, true.
If you hadn't noticed, this is my first time working on an open source
project. If I'm interfering too much, let me know.
I'm still trying to get comfortable with the KDE codebase, which
accounts for all my questions as to where things come from etc.
and I'm also still learning the ropes in how communication works on OS
projects. i.e. what the heirarchy is, how to collaborate over design
decisions, etc.
~Keith
--
------------------------------------------------------------------------
Keith Kyzivat
e: kkyzivat@attbi.com
h: (978) 635-0387
w: (508) 520-3850
c: N/A
--------------060309010409020109060901
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta http-equiv="Content-Type" content="text/html;charset=ISO-8859-1">
<title></title>
</head>
<body>
Say, Simon, Paul,<br>
It appears that an API change happened somewhere between KDE2.2->3.1
regarding Javascript, and the kdelibs developers overlooked<br>
updating some #ifdefed code for QT/E.<br>
<br>
Do you have any ideas on what approach should we take to fix these
several bugs?<br>
<br>
Why is there a need for this Konqueror class, what is the _Konqueror
property, and what does KonquerorFunc do?<br>
(I'm guessing they're all related)...<br>
<br>
~Keith<br>
<br>
-------- Original Message --------
<table cellpadding="0" cellspacing="0" border="0">
<tr>
<th valign="baseline" align="right" nowrap="nowrap">Subject: </th>
<td>Re: Design decisions required...</td>
</tr>
<tr>
<th valign="baseline" align="right" nowrap="nowrap">Date: </th>
<td>Mon, 17 Mar 2003 11:47:24 -0500</td>
</tr>
<tr>
<th valign="baseline" align="right" nowrap="nowrap">From: </th>
<td>Keith Kyzivat <a class="moz-txt-link-rfc2396E" href="mailto:kkyzivat@attbi.com"><kkyzivat@attbi.com></a></td>
</tr>
<tr>
<th valign="baseline" align="right" nowrap="nowrap">To: </th>
<td>Luciano Montanaro <a class="moz-txt-link-rfc2396E" href="mailto:mikelima@virgilio.it"><mikelima@virgilio.it></a></td>
</tr>
<tr>
<th valign="baseline" align="right" nowrap="nowrap">References: </th>
<td><a class="moz-txt-link-rfc2396E" href="mailto:3E70D320.9080804@attbi.com"><3E70D320.9080804@attbi.com></a>
<a class="moz-txt-link-rfc2396E" href="mailto:200303171057.13416.mikelima@virgilio.it"><200303171057.13416.mikelima@virgilio.it></a>
<a class="moz-txt-link-rfc2396E" href="mailto:3E75CB6D.6000601@attbi.com"><3E75CB6D.6000601@attbi.com></a>
<a class="moz-txt-link-rfc2396E" href="mailto:200303171653.02066.mikelima@virgilio.it"><200303171653.02066.mikelima@virgilio.it></a></td>
</tr>
</table>
<br>
<br>
<pre>Luciano Montanaro wrote:
>mandag 17 mars 2003, 14:19, skrev du :
>
>
>Sorry for the delay, I was testing the new stubs for KURIFilter.
>I'll commit them in a few minutes, so that the define is not needed anymore.
>
Sounds great! I actually can get away without having clipboard support,
but of course, I'm sure those people that want to use it
on PDAs probably want clipboard support.
>You can find my config.log file in the attachment, together with the script
>I use to compile konq-e. I usually call it like
>
>.localconfigure
>
>or .localconfigure debug
>
Ok, I'll take a look at it.
>For some strange reason the non-debug version does not currently work well
>on my computer (it tends to crash) but works fine on the set-top-box we are
>developing for.
>The -DQT_NO_CLIPBOARD was defined by the script, by the way, so that
>the default Qt library could be used.
>
I'll keep that in mind.
Oh, and I found a few other bugs which I've currently stubbed (no doubt,
they'll come back to haunt me at runtime):
kjs_<a class="moz-txt-link-freetext" href="window.cpp:510-516">window.cpp:510-516</a> - there is no constructor taking an ExecState*
and a UString defined. I simply #if 0'ed it out, removing a response to
the _Konqueror property. It will fall to the default of Undefined()
when someone asks for it.
kjs_<a class="moz-txt-link-freetext" href="window.cpp:1987">window.cpp:1987</a> - a KonquerorFunc does not derive from Value. Also -
I smell a memory leak if it was to work. - I just stubbed it by
returning Undefined()
The makefiles konq-embed/{lib,src}/Makefile (and associated automake and
in files) explicitly link to qt-mt. Shouldn't this be determined by
configure and it's command line args?
I manually hacked them for qte
>>Thank you for all your help Luciano. I really appreciate it.
>>
>>
>
>You are welcome, with more people working on this, we'll have a better
>browser sooner.
>
True, true.
If you hadn't noticed, this is my first time working on an open source
project. If I'm interfering too much, let me know.
I'm still trying to get comfortable with the KDE codebase, which
accounts for all my questions as to where things come from etc.
and I'm also still learning the ropes in how communication works on OS
projects. i.e. what the heirarchy is, how to collaborate over design
decisions, etc.
~Keith
</pre>
<br>
<div class="moz-signature">-- <br>
<meta http-equiv="content-type" content="text/html; charset=ISO-8859-1">
<title>Work Signature</title>
<meta name="author" content="Keith Kyzivat">
<hr style="width: 100%; height: 2px;">Keith Kyzivat<br>
<font size="-1">e:</font> <span style="color: rgb(102, 0, 204);"><a class="moz-txt-link-abbreviated" href="mailto:kkyzivat@attbi.com">kkyzivat@attbi.com</a></span><br>
<font size="-1">h:</font> <span style="color: rgb(102, 0, 204);">(978)
635-0387</span><br>
<font size="-1">w:</font> <span style="color: rgb(102, 0, 204);">(508)
520-3850</span><br>
<font size="-1">c:</font> <span style="color: rgb(102, 0, 0);">N/A</span><br>
</div>
</body>
</html>
--------------060309010409020109060901--