[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Luigi Toscano bugzilla_noreply at kde.org
Mon Jul 22 08:46:12 BST 2019


https://bugs.kde.org/show_bug.cgi?id=390024

Luigi Toscano <luigi.toscano at tiscali.it> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |https://commits.kde.org/kom
                   |                            |pare/5f7444b061b6453aad2ede
                   |                            |25a598cf175893eb89

--- Comment #16 from Luigi Toscano <luigi.toscano at tiscali.it> ---
Git commit 5f7444b061b6453aad2ede25a598cf175893eb89 by Luigi Toscano, on behalf
of Jeremy Whiting.
Committed on 22/07/2019 at 07:45.
Pushed by ltoscano into branch 'Applications/19.08'.

Fix browse for files/folders doesn't enable "Compare" button.

Since KUrlComboBox::setUrl doesn't emit textChanged (by design according
to it's documentation) we need to emit a signal from FilesPage when
we set the url programatically so the kompareurldialog knows something
changed and to enable the button if both boxes have content.

(cherry picked from commit 006f36d3628bf4da18fe474f470694828904c197)

M  +2    -1    kompareurldialog.cpp
M  +1    -0    libdialogpages/filespage.cpp
M  +7    -0    libdialogpages/filespage.h

https://commits.kde.org/kompare/5f7444b061b6453aad2ede25a598cf175893eb89

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Kompare-devel mailing list