[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

[Jeremy Whiting]

https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #6 from Jeremy Whiting <jpwhiting at kde.org> ---
https://cgit.kde.org/kio.git/commit/?id=ffffa43aea3ebc697fad4be8be821b94c8374d08
is definitely the cause undoing the bits of that commit in kurlrequester.cpp
fix the bug, but I'm not sure why yet. We are connecting to KURLRequester's
textChanged signal in kompare, but we are changing the KURLRequester's
KUrlComboBox itself with setUrl when those buttons are clicked.
KUrlComboBox::setUrl turns off its own signals, so I don't see how that ever
worked except that we were connected to the lineedit rather than the QComboBox
I guess.

A simple fix is in KUrlComboBox setUrl to emit textChanged after changing the
url in setUrl, but I'm not sure if that makes the most sense or not.

-- 
You are receiving this mail because:
You are the assignee for the bug.