[kompare] [Bug 344747] New: libkomparediff2 floaty soversion

[Harald Sitter]

https://bugs.kde.org/show_bug.cgi?id=344747

            Bug ID: 344747
           Summary: libkomparediff2 floaty soversion
           Product: kompare
           Version: unspecified
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: kompare-devel at kde.org
          Reporter: sitter at kde.org

on git master

objdump -p /usr/lib/x86_64-linux-gnu/libkomparediff2.so |grep NAME              
  SONAME               libkomparediff2.so.5.0

it would be very lovely if the SOVERSION attribute of set_target_properties
could use the single digit SOVERSION defined for ecm_setup_version. Using a
floaty SOVERSION is not very common and can screw over packagers who pay close
attention to soversioning of libraries.


diff --git a/CMakeLists.txt b/CMakeLists.txt
index 3712a6f..9b12568 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -64,7 +64,7 @@ target_link_libraries(komparediff2
 target_include_directories(komparediff2 INTERFACE
"$<INSTALL_INTERFACE:${INCLUDE_INSTALL_DIR}/libkomparediff2>")

 set_target_properties(komparediff2 PROPERTIES VERSION
${LIBKOMPAREDIFF2_VERSION_STRING}
-SOVERSION ${LIBKOMPAREDIFF2_VERSION_STRING} )
+SOVERSION 5)

 install(TARGETS komparediff2 EXPORT LibKompareDiff2Targets
${INSTALL_TARGETS_DEFAULT_ARGS})


Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.