unifying libdiff2
Kevin Kofler
kevin.kofler at chello.at
Sat Jul 20 22:25:25 UTC 2013
Hi Jeremy,
On Friday 19 July 2013 at 17:59:33, Jeremy Whiting wrote:
> Thanks for the guidance. I did decide the actions and such do belong
> inside KompareModelList afterall, and found a way to make KomparePart get
> the actions from the KompareModelList and add them to it's own
> actionCollection. I've pushed a branch to kompare called movelibdiff2 if
> you want to take a look. It works ok here, but I'll let you guys see what
> you think of my solution.
>
> My libdiff2 is at scratch/whiting/libdiff2 and builds by itself and
> installs a LibKompareDiff2Config.cmake file that libdialogpages on my
> branch uses to find LibKompareDiff2 variables to build against.
I looked at your changes, everything looks fine to me, so:
Ship it!
Kevin Kofler
More information about the Kompare-devel
mailing list