Bug 137826 - "next file" button does not work when used first thing in a new session

[Konstantin Tokarev]

13.06.2012, 17:47, "Jean-Nicolas Artaud" <jeannicolasartaud at gmail.com>:
> 2012/6/13 Konstantin Tokarev <annulen at yandex.ru>
>> 13.06.2012, 16:11, "Jean-Nicolas Artaud" <jeannicolasartaud at gmail.com>:
>>> 2012/6/13 Konstantin Tokarev <annulen at yandex.ru>
>>>> 12.06.2012, 17:59, "Jean-Nicolas Artaud" <jeannicolasartaud at gmail.com>:
>>>>> Hello,Sorry but I didn't succeed with the review board, only know the git one :-(
>>>>
>>>> http://techbase.kde.org/Development/Review_Board#Using_Review_Board_With_Subversion
>>>>
>>>> It's possible to submit git-originated patches there too, but they need to be modifed to look like
>>>> svn diffs
>>>>
>>>>> BTW, I have a patch to fix the bug 137826.
>>>>> Could you please review it and/or guide me a bit more to use the review board ?
>>>>
>>>> 1. Don't compare boolean return value with 0 - it's incorrect even if old code does that.
>>> Ok, fixed.
>>>> 2. I don't like name of openParseDiffOutput function.
>>> How would you call it.
>>
>> parseAndOpenDiff
> Ok, really nice, I'll put this in the next patch :-)

You can also add dfaure to reviewers - sometimes he does reviews for Kompare too.

-- 
Regards,
Konstantin