[Bug 252359] Kompare could not parse some patch files

Kevin Kofler kevin.kofler at chello.at
Sat Sep 25 18:55:38 CEST 2010


https://bugs.kde.org/show_bug.cgi?id=252359





--- Comment #5 from Kevin Kofler <kevin kofler chello at>  2010-09-25 18:55:35 ---
So the idea behind that patch was that malformed diffs with incorrect line
counts were being accepted without any complaints, and some parts of the diffs
were just interpreted as comments and not shown. For example, in this testcase:
http://ktown.kde.org/~fredrik/folderview.diff
where the line counts "@@ -57,8 +56,10 @@" are incorrect (should be "@@ -57,8
+56,9 @@"), it was just eating the second hunk without warning. So I made that
change to not just skip random junk, but complain about it.

That patch will NOT make Kompare reject a patch entirely though (it'll only
complain), and it's also only in 4.5, not 4.4, so this is not the patch which
is causing your original bug, it's a separate issue.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Kompare-devel mailing list