[Bug 202457] "Next Difference/File" crashes when viewing a "move" diff

[Kevin Kofler]

https://bugs.kde.org/show_bug.cgi?id=202457


Kevin Kofler <kevin.kofler at chello.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |




--- Comment #9 from Kevin Kofler <kevin kofler chello at>  2010-02-16 00:53:42 ---
To Jakub Wieczorek (I'll forward this as he doesn't seem to be registered in
Bugzilla):

Uh, no, your change didn't fix this bug! I tried backporting this change to 4.4
(but didn't commit) and it still crashes (which is why I didn't commit it).
KompareNavTreePart::setSelectedFile still calls currentFile->fillChangesList
with a NULL currentFile. Needless to say, this crashes. And I don't think your
previous patch (which I didn't backport) fixes that either, at least I don't
see how it would.

In addition, your change makes the tree look worse for the testcase attached to
this bug. The / and dev/ portion of the tree shows up twice.

Please test with:
kompare https://bugs.kde.org/attachment.cgi?id=35833
and move down to the next diff.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.