[PATCH] Get rid of the Qt3 Support usage: part 1.

Kevin Kofler kevin.kofler at chello.at
Mon Feb 15 10:52:24 CET 2010


On Sunday 14 February 2010, Jakub Wieczorek wrote:
> There's still some code using Qt3/KDE3 Support libraries in Kompare.

Yes, because to be honest I didn't give a darn as long as it works. :-)

> Some of it seems to be trivial to port to Qt 4.

You're welcome to do it, but…

> Attached is a patch that removes the usage of Q3PtrDict in favor of QMap

… are you sure that QMap is the right class to use? The Qt 4 porting guide 
says the replacement of Q3Dict and Q3PtrDict is QHash.

> and removes some other code, which is not needed any more.

Yeah, looks like using a comparison function is a better solution than 
reimplementing the whole sorting. :-) (I didn't like this when it went in in 
the first place, but it fixed a bug.)

> It would be great if someone could have a look at it.

Done, see above. :-) The QMap vs. QHash issue is something we should get 
sorted out, but otherwise it looks good.

        Kevin Kofler


More information about the Kompare-devel mailing list