[Bug 76904] bug with saving a diff, cannot upload file

Otto Bruggeman bruggie at gmail.com
Tue Feb 24 02:23:00 CET 2009


Otto Bruggeman <bruggie at gmail.com> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #4 from Otto Bruggeman <bruggie gmail com>  2009-02-24 02:22:55 ---
SVN commit 930684 by bruggie:

Many changes related to passing filename information from the part to
the modellist. The Kompare::Infostruct was already in place to update
everyone about changes but it was not used to communicate between the
part and model this commit fixes that. 

The real reason for this commit is that it fixes saving remote files. 
Do not give a local URL and pretend it is a remote URL, does not work. 
KIO::NetAccess::upload then simply does nothing because the file 
already exists.  

Refresh is fixed now. Refetch the files and dont reuse the local files
to determine the differences. Now that saving remote works it showed the
old result again. Some had already seen this, now it was easy to figure
out where it came from.

Fixed a silly copy and paste error where for the destination directory
source was used. Always fun these bugs.

Updated the caption in the titlebar to now have a " -- " to separate the
files so it is more clear which files/directories are compared. I read
somewhere in a bugreport people did not like this so fixed as well.

CCBUG:126870 Patch applied, second hunk not since this is not related

 M  +58 -29    komparepart/kompare_part.cpp  
 M  +74 -71    libdiff2/komparemodellist.cpp  
 M  +12 -15    libdiff2/komparemodellist.h  

WebSVN link: http://websvn.kde.org/?view=rev&revision=930684

Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the Kompare-devel mailing list